This repository has been archived by the owner on Sep 6, 2024. It is now read-only.
5 define a streaming protocol #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanG077
suggested changes
Feb 25, 2024
There was a problem hiding this comment.
Looks good. Add a test using the stream FIFO from DfConv. See the existing test using axi stream in https://github.com/clash-lang/clash-protocols/blob/main/tests/Tests/Protocols/Axi4.hs#L267
|
Also make the merge target of this pr |
rowanG077
reviewed
Feb 28, 2024
JasmijnB
requested review from
Baublesaurus,
Akribes,
Daanww,
MatthijsMu,
JLaumen and
bryanrinders
rowanG077
force-pushed
the
5-define-a-streaming-protocol
branch
2 times, most recently
from
2cb4378 to
91113bf
Compare
JLaumen
approved these changes
Feb 28, 2024
|
Only open thing is the test |
Akribes
approved these changes
Feb 28, 2024
rowanG077
force-pushed
the
5-define-a-streaming-protocol
branch
from
91113bf to
cb02a9e
Compare
rowanG077
force-pushed
the
5-define-a-streaming-protocol
branch
from
cb02a9e to
5af9bfb
Compare
Baublesaurus
reviewed
Mar 1, 2024
MatthijsMu
reviewed
Mar 1, 2024
rowanG077
force-pushed
the
5-define-a-streaming-protocol
branch
from
cb6dd83 to
3a094e9
Compare
bryanrinders
approved these changes
Mar 1, 2024
rowanG077
approved these changes
Mar 1, 2024
MatthijsMu
approved these changes
Mar 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up for review