Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore for ServerKeepAlivePacket #664

Merged
merged 3 commits into from
May 28, 2020
Merged

Add ignore for ServerKeepAlivePacket #664

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf279a0
Add ingore for ServerKeepAlivePacket
rtm516 May 26, 2020
cbe8093
Update PacketTranslatorRegistry.java
rtm516 May 28, 2020
3398937
Add comments explaining why we ignore packets
Camotoy May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ...or/src/main/java/org/geysermc/connector/network/translators/PacketTranslatorRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,18 @@

package org.geysermc.connector.network.translators;

import java.util.HashMap;
import java.util.Map;

import com.github.steveice10.mc.protocol.packet.ingame.server.ServerKeepAlivePacket;
import com.github.steveice10.mc.protocol.packet.ingame.server.world.ServerUpdateLightPacket;
import com.github.steveice10.packetlib.packet.Packet;
import com.nukkitx.protocol.bedrock.BedrockPacket;
import it.unimi.dsi.fastutil.objects.ObjectArrayList;
import org.geysermc.connector.GeyserConnector;
import org.geysermc.connector.network.session.GeyserSession;

import com.github.steveice10.packetlib.packet.Packet;
import com.nukkitx.protocol.bedrock.BedrockPacket;
import org.reflections.Reflections;

import java.util.HashMap;
import java.util.Map;

public class PacketTranslatorRegistry<T> {
private final Map<Class<? extends T>, PacketTranslator<? extends T>> translators = new HashMap<>();

Expand Down Expand Up @@ -72,7 +72,8 @@ public class PacketTranslatorRegistry<T> {
}
}

IGNORED_PACKETS.add(ServerUpdateLightPacket.class);
IGNORED_PACKETS.add(ServerKeepAlivePacket.class); // Handled by MCProtocolLib
IGNORED_PACKETS.add(ServerUpdateLightPacket.class); // Light is handled on Bedrock for us
}

private PacketTranslatorRegistry() {
Expand Down