Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore for ServerKeepAlivePacket #664

Merged
merged 3 commits into from
May 28, 2020

Conversation

rtm516
Copy link
Member

@rtm516 rtm516 commented May 26, 2020

This adds ServerKeepAlivePacket as a packet to ignore as its likely not to be implemented soon and this will prevent it from spamming console with Could not find packet for ServerKeepAlivePacket

This adds ServerKeepAlivePacket as a packet to ignore as its likely not to be implemented soon and this will prevent it from spamming console with `Could not find packet for ServerKeepAlivePacket`
@Camotoy
Copy link
Member

Camotoy commented May 26, 2020

The server will frequently send out a keep-alive, each containing a random ID. The client must respond with the same packet. How does Geyser manage this keep alive currently?

@Camotoy Camotoy changed the title Add ingore for ServerKeepAlivePacket Add ignore for ServerKeepAlivePacket May 26, 2020
@Redned235
Copy link
Member

The server will frequently send out a keep-alive, each containing a random ID. The client must respond with the same packet. How does Geyser manage this keep alive currently?

It doesn't currently. I think we should instead handle this packet instead of ignoring it.

@Tim203
Copy link
Member

Tim203 commented May 28, 2020

If you ignore the packet for more then 30 seconds, you will time out. So it is already handled.

@Camotoy
Copy link
Member

Camotoy commented May 28, 2020

https://github.com/Steveice10/MCProtocolLib/blob/master/src/main/java/com/github/steveice10/mc/protocol/ClientListener.java is the link Tim sent me. Once the packet ignore list is alphabetized I'll approve this.

@Camotoy Camotoy merged commit 3f76ae1 into GeyserMC:master May 28, 2020
@rtm516 rtm516 deleted the ignore-serverkeepalivepacket branch May 28, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants