Emulate client side vehicle movement #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kas-tle
added
the
PR: Needs Testing
Camotoy
reviewed
May 15, 2024
core/src/main/java/org/geysermc/geyser/entity/vehicle/VehicleComponent.java
Outdated
Show resolved
Hide resolved
Redned235
previously requested changes
May 15, 2024
core/src/main/java/org/geysermc/geyser/entity/vehicle/ClientVehicle.java
Outdated
Show resolved
Hide resolved
AJ-Ferguson
added
the
PR: Needs review
AJ-Ferguson
force-pushed
the
client-vehicle
branch
from
59995a1
to
c348928
Compare
onebeastchris
approved these changes
Jun 16, 2024
core/src/main/java/org/geysermc/geyser/translator/protocol/java/JavaRespawnTranslator.java
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/level/block/BlockStateValues.java
Show resolved
Hide resolved
Camotoy
reviewed
Jun 19, 2024
|
|
||
| ServerboundMoveVehiclePacket moveVehiclePacket = new ServerboundMoveVehiclePacket(javaPos.getX(), javaPos.getY(), javaPos.getZ(), rotation.getX(), rotation.getY()); | ||
| vehicle.getSession().sendDownstreamPacket(moveVehiclePacket); | ||
| vehicle.getSession().setLastVehicleMoveTimestamp(System.currentTimeMillis()); |
There was a problem hiding this comment.
Not specifically a requirement now, but if we're tracking ticks we might be able to revisit some of these currentTimeMillis calls.
core/src/main/java/org/geysermc/geyser/translator/collision/BlockCollision.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/translator/level/block/entity/PistonBlockEntity.java
Outdated
Show resolved
Hide resolved
|
After testing this out, everything is working fine, the only issue I noticed is that the animation of the strider seems to be broken, it moves standstill . |
XingLingQAQ
pushed a commit
to XingLingQAQ/Geyser
that referenced
this pull request
Sep 25, 2024
* WIP client side vehicles * Address reviews and remove use of Optional * Only tick active vehicle * Track world ticks * Fixes for Camel dash and pose transition * Remove vehicle parameter * Start using blocks refactor * Update BlockRegistryPopulator * Update blocks * Support step height attribute * Use climbable block tag and TrapDoorBlock * Lock camel rotation if stationary * Fix boost ticking * Keep cache of surrounding blocks * Fix bug causing BoundingBox position to change in CollisionManager * Clamp user input * Support weaving status effect * Support gravity attribute * Piston support * Tick boost for Pig and Strider if any player is controlling * Submodule * Address some reviews * Support world border * Optimize world border check * Small optimizations * Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for vehicles that are controlled by the client (Camel, Strider, Pig).
Movement should be extremely close to a real java client, and many situations are accurately handled such as fluid, slime and honey blocks, climbing, etc.
Todo
PistonsTick vehicle boost if any player is controlling