Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectator mode is not working #3769

Closed
patyhank opened this issue May 13, 2023 · 1 comment
Closed

Spectator mode is not working #3769

patyhank opened this issue May 13, 2023 · 1 comment

Comments

@patyhank
Copy link
Contributor

patyhank commented May 13, 2023

Describe the bug

In spectator mode
Because AbilityLayer.Type.SPECTATOR has never been added to the UpdateAbilitiesPacket
so you can't fly and noclip with the default Abilities

To Reproduce

  1. /gamemode spectator
  2. Move to the inside of the block
  3. Player will keep falling down

Expected behaviour

Player will not keep falling

Screenshots / Videos

Youtube Reproduce: https://youtu.be/2HEQNU90WNU
Patched Workaround: https://youtu.be/rKMsBt_F9uo

Server Version and Plugins

No response

Geyser Dump

No response

Geyser Version

2.1.0-SNAPSHOT (git-master-870a838)

Minecraft: Bedrock Edition Device/Version

1.19.81

Additional Context

A simple workaround

abilityLayer.setLayerType(AbilityLayer.Type.BASE);
to

        if (spectator) {
            abilityLayer.setLayerType(AbilityLayer.Type.SPECTATOR);
        } else {
            abilityLayer.setLayerType(AbilityLayer.Type.BASE);
        }
@Camotoy
Copy link
Member

Camotoy commented May 13, 2023

PRs are more than welcome!

patyhank added a commit to patyhank/Geyser that referenced this issue May 13, 2023
onebeastchris pushed a commit to onebeastchris/Geyser that referenced this issue May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants