fix: changing orientation attachment picker issues #2687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Solves this GH issue. Details of the reproduction steps can be found in the issue itself.
🛠 Implementation details
Here is a brief summary of why this issue is happening:
containerHeight
property in the library as well as looking at the implementation for a bit, we can clearly see that:containerHeight
; theBottomSheet
is however not shown as it's being controlled entirely by ourOverlayProvider
containerHeight
is wrong; only to be updated soon afterBottomSheet
is displayed without any of its actual functionalitiesThe issue is reproducible on virtually any screen by the way, since the
OverlayProvider
is basically theroot
of our DOM tree.🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
develop
branch