Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛] White ghost modal issue still exist #2655

Closed
8 tasks
sraut1 opened this issue Sep 5, 2024 · 12 comments
Closed
8 tasks

[🐛] White ghost modal issue still exist #2655

sraut1 opened this issue Sep 5, 2024 · 12 comments

Comments

@sraut1
Copy link

sraut1 commented Sep 5, 2024

Issue

This issue occurs on intermittently on keyboard hide and also regularly when app is switched from portrait to landscape. here is the video

355995836-ec9180e8-8623-4b58-8ee6-2d58b2538684.mov
Screenshot 2024-09-05 at 10 35 30 AM

Steps to reproduce

Steps to reproduce the behavior:

  1. Play a YouTube video using the YouTubePlayer component (react-native-youtube-iframe).
  2. Switch the video to fullscreen mode.
  3. Rotate the device to landscape orientation while in fullscreen mode.
  4. Rotate back to portrait mode
  5. Exit fullscreen mode.

Expected behavior

Project Related Information

Device: iPhone 15 Pro or Galaxy S23
OS + version: iOS 17.4
Expo verison 51.0.24
stream-chat-expo: 5.36.1
stream-chat-react-native: 5.34.0
gorhom/bottom-sheet: 4.6.4 via stream-chat-react-native-core

Customization

Click To Expand

# N/A

Offline support

  • I have enabled offline support.
  • The feature I'm having does not occur when offline support is disabled. (stripe out if not applicable)

Environment

Click To Expand

package.json:

# N/A

react-native info output:

 OUTPUT GOES HERE
  • Platform that you're experiencing the issue on:
    • iOS
    • Android
    • iOS but have not tested behavior on Android
    • Android but have not tested behavior on iOS
    • Both
  • stream-chat-react-native version you're using that has this issue:
    • e.g. 5.4.3
  • Device/Emulator info:
    • I am using a physical device
    • OS version: e.g. Android 10
    • Device/Emulator: e.g. iPhone 11

Additional context

Screenshots

Click To Expand


@sraut1
Copy link
Author

sraut1 commented Sep 5, 2024

@santhoshvai @vanGalilea

@sraut1
Copy link
Author

sraut1 commented Sep 5, 2024

@khushal87 I saw check was added in latest version to open AttachmentPicker. but still AttachmentPicker is getting opened randomly in the app:

{isImageMediaLibraryAvailable() ? ( <AttachmentPicker ref={bottomSheetRef} {...attachmentPickerProps} /> ) : null}

isImageMediaLibraryAvailable() is always true

@khushal87
Copy link
Member

Hey @sraut1, the isImageMediaLibraryAvailable() is true because the cameraroll dependency is there for you in your project. We also introduced an option to switch to a native image picker, so maybe you can try that out.

Here is the guide - https://getstream.io/chat/docs/sdk/reactnative/guides/native-image-picker/

@sraut1
Copy link
Author

sraut1 commented Sep 6, 2024

Hey Thanks for the response @khushal87 we do allow camera/gallery access in the app but through expo-camera, we are not using camera roll for chat functionality though. but even though someone is using react-native-camera-roll, AttachmentPicker popping randomly in the app is buggy. any suggestion?

@khushal87
Copy link
Member

Yeah, for the expo, it should be expo-media-library for your case. About the issue with the attachment picker, we will triage it and get back to you once it's reproducible. Thanks 😄

@sraut1
Copy link
Author

sraut1 commented Sep 6, 2024

Thanks @khushal87 removing expo-media-library resolves the issue as isImageMediaLibraryAvailable() returns false.

@khushal87
Copy link
Member

Fixed with #2687

@arekkubaczkowski
Copy link

arekkubaczkowski commented Oct 7, 2024

well, this issue still exist on the latest (5.39.1) version.
this happens after orientation change.

cc @khushal87
image

@arekkubaczkowski
Copy link

should we reopen it?

@khushal87
Copy link
Member

Hey @arekkubaczkowski, I don't see this problem when using the keyboard or the image gallery on the latest version when I change orientation as well.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-08.at.11.27.00.mp4

@arekkubaczkowski
Copy link

arekkubaczkowski commented Oct 8, 2024

well, on your video the bottom sheet appears for a moment, I believe this is not a desired behavior, in my case it just shows for a bit longer.

@khushal87
Copy link
Member

Yes, the flickering is a well-known issue for bottom sheet package - gorhom/react-native-bottom-sheet#516 and I don't see there's a fix yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants