feat: use queryReactions to fetch and show reactions in OverlayReactions. #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushal87
commented
Jun 6, 2024
| @@ -63,33 +63,6 @@ export const addReactionToLocalState = < | |||
| message.reaction_groups[currentReaction.type].sum_scores - 1; | |||
| } | |||
|
|
|||
| if (!message.reaction_groups) { | |||
There was a problem hiding this comment.
There was repetitive code, hence removed.
santhoshvai
reviewed
Jun 10, 2024
| reactions: fetchedReactions, | ||
| } = useFetchReactions({ | ||
| messageId, | ||
| sort: { created_at: -1 }, |
There was a problem hiding this comment.
Suggested change
| sort: { created_at: -1 }, | |
| sort: { created_at: -1 }, |
I think we should move this to a const outside, so that inside the hook useMEmo stringify does not trigger again and again..
its a simple optimisation
santhoshvai
reviewed
Jun 10, 2024
Comment on lines
120
to
128
| const reactions = | ||
| propReactions || | ||
| (fetchedReactions.map((reaction) => ({ | ||
| alignment: 'left', | ||
| id: reaction.user?.id, | ||
| image: reaction.user?.image, | ||
| name: reaction.user?.name, | ||
| type: reaction.type, | ||
| })) as Reaction[]); |
There was a problem hiding this comment.
we should useMemo this I think.. so that we dont map unnecessarily if the fetched reactions are the same
santhoshvai
approved these changes
Jun 10, 2024
|
🎉 This PR is included in version 5.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR focuses on using the
client.queryReactionsAPI to show reactions in the OverlayReactions instead of what was used before(message.latest_reactions). Optimistic fetching of reactions from local DB is present and is also handled in the PR.Note: The
reactionstype could have beenReactionsResponseand that would make the code much cleaner but sadly that would be a breaking change so the response from the API is mapped to the existingReactiontype.Also, this PR is to be reviewed and merged once #2523 is merged.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch