fix: derive reaction list from reaction_groups and show reaction count while maintaining the order #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushal87
changed the title
khushal87
changed the title
oliverlaz
reviewed
May 27, 2024
6 tasks
khushal87
commented
May 31, 2024
| @@ -30,7 +30,7 @@ import type { PreparedQueries, Table } from './types'; | |||
| * | |||
| */ | |||
| export class QuickSqliteClient { | |||
| static dbVersion = 3; | |||
| static dbVersion = 4; | |||
santhoshvai
reviewed
Jun 6, 2024
Comment on lines
69
to
71
|
|
||
| export const useProcessReactions = < | ||
| StreamChatGenerics extends DefaultStreamChatGenerics = DefaultStreamChatGenerics, |
There was a problem hiding this comment.
can you add a small documentation of this hook of what it does please.. useful for future maintenance
santhoshvai
reviewed
Jun 6, 2024
santhoshvai
reviewed
Jun 6, 2024
santhoshvai
reviewed
Jun 6, 2024
package/src/utils/utils.ts
Outdated
Comment on lines
30
to
32
| export type ReactionData = { | ||
| Icon: React.ComponentType<IconProps>; | ||
| Icon: React.ComponentType; | ||
| type: string; |
There was a problem hiding this comment.
is this change necessary?, seems like its making the type looser now..
There was a problem hiding this comment.
I saw how this is used
There was a problem hiding this comment.
intuiverly it seems like this removal should not be done to me
There was a problem hiding this comment.
I think this is better
Icon: React.ComponentType<Partial<IconProps>>;
Supports just a normal Text component and also integrators get to add support for the icon props if they want for SVG override
santhoshvai
approved these changes
Jun 6, 2024
|
🎉 This PR is included in version 5.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch