Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lpsolve external libraries #141

Closed
vissarion opened this issue Mar 4, 2021 · 4 comments · Fixed by #183
Closed

Remove lpsolve external libraries #141

vissarion opened this issue Mar 4, 2021 · 4 comments · Fixed by #183
Labels
good first issue

Comments

@vissarion
Copy link
Member

Is your feature request related to a problem? Please describe.
External libraries consume space in the repository and have to be updated manually.

Describe the solution you'd like
Remove lpsolve from external folder and download them in cmake before building the package or whenever needed.

See how this was done for eigen #131
@backbencher00
Copy link

sir could you assign me this issue, I would like to work on this

@vissarion
Copy link
Member Author

vissarion commented Mar 21, 2021 via email

@ManavShah05
Copy link

I have created a pull request here: #149

@vissarion
Copy link
Member Author

I have created a pull request here: #149

Thanks, please link this issue on your PR (there is a option in the PR page).

@vissarion vissarion linked a pull request Mar 31, 2021 that will close this issue
Remove lpsolve external libraries #149
Closed
@ManavShah05 ManavShah05 mentioned this issue Mar 31, 2021
Closed
@pradeexsu pradeexsu mentioned this issue Mar 31, 2021
Closed
@vaithak vaithak mentioned this issue Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
3 participants
@vissarion @backbencher00 @ManavShah05