Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all .cmake files in one directory #151

Closed
pradeexsu opened this issue Mar 31, 2021 · 0 comments · Fixed by #190
Closed

Put all .cmake files in one directory #151

pradeexsu opened this issue Mar 31, 2021 · 0 comments · Fixed by #190
Labels

Comments

@pradeexsu
Copy link

pradeexsu commented Mar 31, 2021

Is your feature request related to a problem?
No, it's not related to any problem, it's about the convention that makes our code more structured.

Request Description
there are only 2 .cmake files Eigen.cmake and Boost.cmake, but in the future, there can be too many .cmake files. like.

and in the future, there can be many .cmake files in volesti.

Solution Description
we can put all these similar kinds of .cmake files in a directory a cmake (we can call any suitable name), and add its path to our root CMakeLists.txt or where ever it's needed. in this way, our code will be more structured.

@vissarion vissarion changed the title we can put all .cmake file in a directory Put all .cmake file in a directory Apr 2, 2021
@vissarion vissarion changed the title Put all .cmake file in a directory Put all .cmake files in one directory Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants