Remove deprecated scipy method pinv2 #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the PR scipy/scipy#13831 Both methods pinv and pinv2 have been using the same algorithms for a long time. Thus, I simply deleted the option pinv2.
This was referenced Aug 4, 2022
|
The failed tests are not a problem of this PR and they are fixed with PR #248 . |
|
Now, all CI runs fail due to the updated scipy-package. I'll just merge this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Scipy v1.9 GSTools fails to import
pinv2, as reported in #246 .According to the PR both methods
pinvandpinv2have been using the same algorithms for a long time. Thus, I simply deleted the optionpinv2.