Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements for Scipy Innacurate #256

Closed
Derekbenj opened this issue Aug 10, 2022 · 1 comment · Fixed by #247
Closed

Requirements for Scipy Innacurate #256

Derekbenj opened this issue Aug 10, 2022 · 1 comment · Fixed by #247
Assignees
Labels
bug Something isn't working external problem
Milestone

Comments

@Derekbenj
Copy link

The requirements suggest that any scipy version greater than or equal to 1.1.0 will support this framework, but as of 1.7.0, 'pinv2' is depreciated from scipy.linalg, after which version the old pinv and pinv2 are consolidated to pinv only. Attempting to import gstools with any scipy version greater than 1.7 fails. As a bandaid fix, line 38 of gstoools/kringe/base.py can be changed from:

P_INV = {"pinv": spl.pinv, "pinv2": spl.pinv2, "pinvh": spl.pinvh}

to

P_INV = {"pinv": spl.pinv, "pinv2": spl.pinv, "pinvh": spl.pinvh}

@MuellerSeb
Copy link
Member

Hi there,
this was already reported here: #246
and is already solved here: #247
It will be part of the next release v1.4 that will come in the next days.

Thanks for your report.

@MuellerSeb MuellerSeb added bug Something isn't working external problem labels Aug 11, 2022
@MuellerSeb MuellerSeb self-assigned this Aug 11, 2022
@MuellerSeb MuellerSeb added this to the v1.4 milestone Aug 11, 2022
@MuellerSeb MuellerSeb linked a pull request Aug 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external problem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants