Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 3.2.x][Fixes #7173] Improve the "get_visibile_reources" method: replace for… #7179

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

afabiani
Copy link
Member

… loop with DB filtering

(cherry picked from commit 33c18dd)

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

… loop with DB filtering

(cherry picked from commit 33c18dd)
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #7179 (164517d) into 3.2.x (761772b) will decrease coverage by 8.35%.
The diff coverage is 2.77%.

@@            Coverage Diff             @@
##            3.2.x    #7179      +/-   ##
==========================================
- Coverage   34.31%   25.95%   -8.36%     
==========================================
  Files         565      565              
  Lines       39999    40021      +22     
  Branches     5290     5288       -2     
==========================================
- Hits        13724    10387    -3337     
- Misses      25518    29190    +3672     
+ Partials      757      444     -313     

afabiani added 2 commits March 28, 2021 22:19
… loop with DB filtering

(cherry picked from commit 236fade)
… loop with DB filtering

(cherry picked from commit 8386552)

# Conflicts:
#	geonode/security/tests.py
@afabiani afabiani merged commit 1ce89cb into 3.2.x Mar 29, 2021
@afabiani afabiani deleted the ISSUE_7173_BKP_3.2.x branch March 29, 2021 07:57
afabiani pushed a commit to geosolutions-it/geonode that referenced this pull request Mar 29, 2021
…urces" method: replace for… (GeoNode#7179)

* [Fixes GeoNode#7173] Improve the "get_visibile_reources" method: replace for loop with DB filtering

(cherry picked from commit 33c18dd)

* [Fixes GeoNode#7173] Improve the "get_visibile_reources" method: replace for loop with DB filtering

(cherry picked from commit 236fade)

* [Fixes GeoNode#7173] Improve the "get_visibile_reources" method: replace for loop with DB filtering

(cherry picked from commit 8386552)

# Conflicts:
#	geonode/security/tests.py
(cherry picked from commit 1ce89cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant