[Hardening] Removing wrong logic check always True

(cherry picked from commit cf95050)
GeoNode · Mar 25, 2021 · 761772b · 761772b
1 parent dc45a92
commit 761772b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/geonode/br/management/commands/utils/utils.py b/geonode/br/management/commands/utils/utils.py
@@ -478,4 +478,4 @@ def empty_folder(folder):
             elif os.path.isdir(file_path):
                 shutil.rmtree(file_path)
         except Exception as e:
-            print('Failed to delete %s. Reason: %s' % (file_path, e))
+            print(f'Failed to delete {file_path}. Reason: {e}')
diff --git a/geonode/geoserver/views.py b/geonode/geoserver/views.py
@@ -372,8 +372,7 @@ def feature_edit_check(request, layername, permission='change_layer_data'):
     if is_admin or is_staff or is_owner or is_manager or request.user.has_perm(
             permission,
             obj=layer) and \
-            ((permission == 'change_layer_data' and layer.storeType == 'dataStore' and feature_edit) or
-             True):
+            layer.storeType == 'dataStore' and feature_edit:
         return HttpResponse(
             json.dumps({'authorized': True}), content_type="application/json")
     else: