Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #7102] All new Styles seem to be called Default Styler, not their actual name #7103

Merged
merged 4 commits into from
Mar 19, 2021

Conversation

luorlandini
Copy link
Contributor

@luorlandini luorlandini commented Mar 18, 2021

References: #7102

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot
Copy link

cla-bot bot commented Mar 18, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @luorlandini on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@afabiani afabiani added this to the 3.2 milestone Mar 18, 2021
@afabiani afabiani added backport 3.2.x PR should be backported to target version backport 3.3.x PR should be backported to target version labels Mar 18, 2021
@afabiani
Copy link
Member

@luorlandini can you please fix formatting issues below?

^@^@geonode/geoserver/helpers.py:80:1: E303 too many blank lines (3)

Copy link
Member

@afabiani afabiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^@^@geonode/geoserver/helpers.py:80:1: E303 too many blank lines (3)

@cla-bot
Copy link

cla-bot bot commented Mar 18, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @luorlandini on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented Mar 18, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @luorlandini on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@afabiani afabiani merged commit 1668930 into GeoNode:master Mar 19, 2021
afabiani pushed a commit that referenced this pull request Mar 19, 2021
…eir actual name (#7103)

* css format style name

* remove unquote

* remove blank lines

Co-authored-by: Alessio Fabiani <[email protected]>
(cherry picked from commit 1668930)
afabiani pushed a commit that referenced this pull request Mar 19, 2021
…eir actual name (#7103)

* css format style name

* remove unquote

* remove blank lines

Co-authored-by: Alessio Fabiani <[email protected]>
(cherry picked from commit 1668930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 3.2.x PR should be backported to target version backport 3.3.x PR should be backported to target version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants