Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All new Styles seem to be called Default Styler, not their actual name #7102

Closed
luorlandini opened this issue Mar 17, 2021 · 3 comments
Closed

All new Styles seem to be called Default Styler, not their actual name #7102

luorlandini opened this issue Mar 17, 2021 · 3 comments
Assignees
@luorlandini
Labels
backport 3.2.x PR should be backported to target version major A high priority issue which might affect a lot of people or large parts of the codebase
Milestone
3.2

Comments

@luorlandini
Copy link
Contributor

Expected Behavior

in the page layer, the name assigned by the style editor must be displayed instead of "Default Styler"

Actual Behavior

when an user make a new style it seems to be always called "Default Styler"

Steps to Reproduce the Problem

  1. Sign in
  2. layers page
  3. choose a layer
  4. click on editing tools
  5. click on Create a new style, choose a style and add it
  6. back in layer page
  7. in the right side, the list style must not have the name "Default Styler"

Specifications

  • GeoNode version: 3.1
  • Installation method (manual, GeoNode Docker, SPCGeoNode Docker): manual
  • Platform:
  • Additional details:
@afabiani afabiani mentioned this issue Mar 18, 2021
Merged
12 tasks
@afabiani afabiani added the major A high priority issue which might affect a lot of people or large parts of the codebase label Mar 18, 2021
@afabiani afabiani added this to the 3.2 milestone Mar 18, 2021
afabiani pushed a commit that referenced this issue Mar 19, 2021
@luorlandini @afabiani
[Fixes #7102] All new Styles seem to be called Default Styler, not th…
0ec303d 
…eir actual name (#7103)

* css format style name

* remove unquote

* remove blank lines

Co-authored-by: Alessio Fabiani <[email protected]>
(cherry picked from commit 1668930)
afabiani pushed a commit that referenced this issue Mar 19, 2021
@luorlandini @afabiani
[Fixes #7102] All new Styles seem to be called Default Styler, not th…
4d27c57 
…eir actual name (#7103)

* css format style name

* remove unquote

* remove blank lines

Co-authored-by: Alessio Fabiani <[email protected]>
(cherry picked from commit 1668930)
@giohappy giohappy added backport 3.2.x PR should be backported to target version backport 3.x labels Mar 19, 2021
@gannebamm
Copy link
Contributor

I think this is behaviour is related to this fix:
If I create a new style its name will get suffixed with an UUID. See this:
grafik

https://master.demo.geonode.org/layers/geonode_master_data:geonode:testsetestest

In the style editor the name test css was given.

@gannebamm gannebamm reopened this Mar 22, 2021
@gannebamm
Copy link
Contributor

The above will get fixed, if the sld_title field gets filled via the admin interface. For CSS styles the name shall be used to fill this field on save.

@afabiani
Copy link
Member

afabiani commented Apr 6, 2021

@gannebamm I'm going to open a specific issue (regression) for this.

@afabiani afabiani closed this as completed Apr 6, 2021
@afabiani afabiani mentioned this issue Apr 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luorlandini luorlandini

Labels
backport 3.2.x PR should be backported to target version major A high priority issue which might affect a lot of people or large parts of the codebase
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
4 participants
@giohappy @afabiani @luorlandini @gannebamm