-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve PyGMT documentation #996
Conversation
@GenericMappingTools/python Is it good to submit revisions for different |
It's situation dependent and a matter of opinion. In my opinion, if you're making big changes to the files, probably best to split it into multiple PRs so all of the file changes aren't dependent on a single PR getting approved. But if it's relatively minor changes (formatting, spelling, adding a single line/description to multiple files) I think they should be grouped together in a single PR. |
Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
@core-man, I appreciate all the improvements you're making here, but this Pull Request is getting a bit large in scope. The general guidelines at https://github.com/GenericMappingTools/pygmt/blob/v0.3.0/CONTRIBUTING.md#general-guidelines recommend that:
In particular, the changes made to the gallery examples might cause some tricky merge conflicts with the gallery reorganization at #995. I suggest you coordinate a bit with @willschlitzer on this matter (i.e. decide who merges their PR first) before things get more complicated. |
Thanks for the suggestion. I agree this PR is a bit large in scope, although I
yes, I also notice #995 which I think should be merged first. |
Co-authored-by: Dongdong Tian <[email protected]>
@core-man Do you want to apply some changes in this PR before v0.3.1? If you do, please open separate PRs for them. |
Okay. |
Close this PR since the revisions have been submitted by the individual PRs. |
Description of proposed changes
Related to #983.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version