-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the link for standard GMT color names in GMT docs #1049
Add the link for standard GMT color names in GMT docs #1049
Conversation
Actually all of the ways listed here are supported: |
Well, except C/M/Y/K it seems. I think this is an upstream bug and will submit an issue. |
Yes, I tested all the color methods. |
Yes, C/M/Y/K works with 0 - 100 values. I've submitted this PR to fix the documentation. This works for me:
|
Great~ works for me, too. |
@meghanrjones two additional color cases were added in 8e6cc3a. Since it is not a GMT color tutorial, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have a couple small recommendations.
Co-authored-by: Meghan Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a tiny suggestion to keep each line shorter than 80 chars.
Co-authored-by: Dongdong Tian <[email protected]>
…Tools#1049) Co-authored-by: Meghan Jones <[email protected]> Co-authored-by: Dongdong Tian <[email protected]>
Description of proposed changes
Add the link of GMT DOC to standard GMT color names.
Related to #983 and #996.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version