Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the link for standard GMT color names in GMT docs #1049

Merged
merged 4 commits into from
Mar 13, 2021

Conversation

core-man
Copy link
Member

Description of proposed changes

Add the link of GMT DOC to standard GMT color names.

Related to #983 and #996.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones
Copy link
Member

Actually all of the ways listed here are supported:
https://docs.generic-mapping-tools.org/dev/gmtcolors.html#description
Would you be able to revise accordingly so that this is clear to the reader?

@maxrjones
Copy link
Member

Actually all of the ways listed here are supported:
https://docs.generic-mapping-tools.org/dev/gmtcolors.html#description
Would you be able to revise accordingly so that this is clear to the reader?

Well, except C/M/Y/K it seems. I think this is an upstream bug and will submit an issue.

@core-man
Copy link
Member Author

Actually all of the ways listed here are supported:
https://docs.generic-mapping-tools.org/dev/gmtcolors.html#description
Would you be able to revise accordingly so that this is clear to the reader?

Well, except C/M/Y/K it seems. I think this is an upstream bug and will submit an issue.

Yes, I tested all the color methods. C/M/Y/K always output white.

@maxrjones
Copy link
Member

Actually all of the ways listed here are supported:
https://docs.generic-mapping-tools.org/dev/gmtcolors.html#description
Would you be able to revise accordingly so that this is clear to the reader?

Well, except C/M/Y/K it seems. I think this is an upstream bug and will submit an issue.

Yes, I tested all the color methods. C/M/Y/K always output white.

Yes, C/M/Y/K works with 0 - 100 values. I've submitted this PR to fix the documentation. This works for me:

import pygmt

fig = pygmt.Figure()
# Make a global Mollweide map with automatic ticks
fig.basemap(region="g", projection="W15c", frame=True)
# Plot the land as light gray, and the water as sky blue
fig.coast(land="#666666", water="100/100/0/0")
fig.show()

@core-man
Copy link
Member Author

Actually all of the ways listed here are supported:
https://docs.generic-mapping-tools.org/dev/gmtcolors.html#description
Would you be able to revise accordingly so that this is clear to the reader?

Well, except C/M/Y/K it seems. I think this is an upstream bug and will submit an issue.

Yes, I tested all the color methods. C/M/Y/K always output white.

Yes, C/M/Y/K works with 0 - 100 values. I've submitted this PR to fix the documentation. This works for me:

import pygmt

fig = pygmt.Figure()
# Make a global Mollweide map with automatic ticks
fig.basemap(region="g", projection="W15c", frame=True)
# Plot the land as light gray, and the water as sky blue
fig.coast(land="#666666", water="100/100/0/0")
fig.show()

Great~ works for me, too.

@core-man
Copy link
Member Author

core-man commented Mar 13, 2021

Actually all of the ways listed here are supported:
https://docs.generic-mapping-tools.org/dev/gmtcolors.html#description
Would you be able to revise accordingly so that this is clear to the reader?

@meghanrjones two additional color cases were added in 8e6cc3a. Since it is not a GMT color tutorial, H-S-V and CMYK are not listed to keep the document simple.

Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a couple small recommendations.

examples/gallery/maps/land_and_water.py Outdated Show resolved Hide resolved
examples/gallery/maps/land_and_water.py Outdated Show resolved Hide resolved
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 13, 2021
@seisman seisman added this to the 0.3.1 milestone Mar 13, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a tiny suggestion to keep each line shorter than 80 chars.

examples/gallery/maps/land_and_water.py Outdated Show resolved Hide resolved
examples/gallery/maps/land_and_water.py Outdated Show resolved Hide resolved
@seisman seisman changed the title Add the link for standard GMT color names in GMT DOC Add the link for standard GMT color names in GMT docs Mar 13, 2021
@seisman seisman merged commit d1287a6 into GenericMappingTools:master Mar 13, 2021
@core-man core-man deleted the improve-land-and-water branch March 13, 2021 20:10
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants