Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace argument with parameter in gallery examples and tutorials #943

Merged

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Feb 21, 2021

As discussed in #886, this pull requests updates the incorrect use of "argument" with "parameter." It covers the the gallery examples and tutorials, except for the files changed in #921 and #922.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added this to the 0.3.1 milestone Feb 21, 2021
@willschlitzer willschlitzer added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Feb 21, 2021
@willschlitzer willschlitzer changed the title Replace argument with parameter in gallery examples Replace argument with parameter in gallery examples and tutorials. Feb 21, 2021
@willschlitzer willschlitzer marked this pull request as ready for review February 21, 2021 20:46
@willschlitzer willschlitzer marked this pull request as ready for review February 22, 2021 20:28
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked the changes you made (not the full documentation). They look good to me.

@seisman
Copy link
Member

seisman commented Feb 22, 2021

This PR should be good to merge if @meghanrjones has no further comments.

@weiji14
Copy link
Member

weiji14 commented Feb 22, 2021

Wait, can we merge @michaelgrund's #922 into this one?

@willschlitzer
Copy link
Contributor Author

Wait, can we merge @michaelgrund's #922 into this one?

I could manually add it in. I just didn't want to step on his toes since he had already opened the PR.

@seisman
Copy link
Member

seisman commented Feb 22, 2021

Wait, can we merge @michaelgrund's #922 into this one?

I could manually add it in. I just didn't want to step on his toes since he had already opened the PR.

See his comment at #922 (comment).

@willschlitzer
Copy link
Contributor Author

Made the changes in #922 and #921.

@seisman seisman changed the title Replace argument with parameter in gallery examples and tutorials. Replace argument with parameter in gallery examples and tutorials Feb 22, 2021
@seisman seisman merged commit 34b30aa into GenericMappingTools:master Feb 22, 2021
@willschlitzer willschlitzer deleted the gallery-frame-argument branch March 2, 2021 21:28
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants