Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace argument by parameter in image.py #921

Closed
wants to merge 3 commits into from

Conversation

michaelgrund
Copy link
Member

Replaced all appearances of argument by parameter.

@michaelgrund michaelgrund marked this pull request as draft February 17, 2021 17:13
@michaelgrund michaelgrund added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Feb 17, 2021
@michaelgrund michaelgrund added this to the 0.3.1 milestone Feb 17, 2021
@seisman
Copy link
Member

seisman commented Feb 17, 2021

Just a quick comment: I don't quite like this example, because it's so similar to the "logo" example (https://www.pygmt.org/dev/gallery/plot/logo.html). Perhaps we can change to a better image?

@michaelgrund
Copy link
Member Author

Just a quick comment: I don't quite like this example, because it's so similar to the "logo" example (https://www.pygmt.org/dev/gallery/plot/logo.html). Perhaps we can change to a better image?

Agree with you @seisman , any suggestions which image we could use instead? Originally I selected this image since it is availabe from the GMT website, so we would know if its origin changes. Alternatively, we could store an example image in the repo.

@seisman
Copy link
Member

seisman commented Feb 23, 2021

Close this one as the changes has been merged into #943. We may still want to improve the example using a better figure.

@seisman seisman closed this Feb 23, 2021
@seisman seisman deleted the gallery-image-update branch February 23, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants