Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vercel configuration file from now.json to vercel.json #738

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 16, 2020

Description of proposed changes

ZEIT changed their name to Vercel (https://vercel.com/blog/zeit-is-now-vercel).
The configuration file now.json also changed to vercel.json.

Fixes #447

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

ZEIT changed their name to Vercel (https://vercel.com/blog/zeit-is-now-vercel).
The configuration file now.json also changed to vercel.json.
@seisman seisman changed the title Rename now.json to vercel.json Rename vercel configuration file from now.json to vercel.json Dec 16, 2020
@seisman seisman added the maintenance Boring but important stuff for the core devs label Dec 16, 2020
@seisman seisman added this to the 0.3.0 milestone Dec 16, 2020
@seisman seisman requested a review from a team December 16, 2020 08:06
@weiji14
Copy link
Member

weiji14 commented Dec 16, 2020

There's some references to 'Zeit Now' at https://github.com/GenericMappingTools/pygmt/blob/master/MAINTENANCE.md#continuous-documentation which we should rename to "Vercel".

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @seisman!

@seisman seisman merged commit e269abf into master Dec 16, 2020
@seisman seisman deleted the now-vercel branch December 16, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ZEIT/now to Vercel
2 participants