Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZEIT/now to Vercel #447

Closed
seisman opened this issue May 21, 2020 · 2 comments · Fixed by #738
Closed

Fix ZEIT/now to Vercel #447

seisman opened this issue May 21, 2020 · 2 comments · Fixed by #738
Labels
help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs

Comments

@seisman
Copy link
Member

seisman commented May 21, 2020

Description of the problem

We use the ZEIT/now service for continuously building the documentation for each commit. Recently, ZEIT changed their name to Vercel (https://vercel.com/blog/zeit-is-now-vercel). The configuration file now.json also changed to vercel.json. We may need to update it accordingly.

I may be wrong here, as I didn't check the documentation carefully.

@weiji14
Copy link
Member

weiji14 commented May 21, 2020

Yes, I did notice it a while back, but everything still seems to work using the Github Now App. There doesn't seem to be a Vercel app (yet?), but there is a Github Action at https://github.com/amondnet/vercel-action that does the same thing I guess.

So we probably don't need to change anything for now. But it would be nice to move to the Github Action at some point as it should allow us to trigger the builds via a command (like /now build?) instead of every commit.

@weiji14 weiji14 added help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs labels May 21, 2020
@seisman
Copy link
Member Author

seisman commented Dec 16, 2020

It seems the only thing we need to do is renaming "now.json" to "vercel.json" (although now.json is still supported).

As for the vercel-action, I don't see any benefits to switch to the action. As per the documentation (https://github.com/amondnet/vercel-action#disable-vercel-for-github), we still need the "vercel.json" file to disable the vercel-github integration. Using the vercel-action means we need three files "vercel.json", "package.json" and the workflow file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants