Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Python 3.9 compatibility #644

Closed
weiji14 opened this issue Oct 8, 2020 · 4 comments · Fixed by #689
Closed

Check Python 3.9 compatibility #644

weiji14 opened this issue Oct 8, 2020 · 4 comments · Fixed by #689
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@weiji14
Copy link
Member

weiji14 commented Oct 8, 2020

Description of the desired feature

Python 3.9 has been released on 2020-10-05. Should check to see if pygmt works well with Python 3.9. See also previous issue for Python 3.8 at #340.

Python 3.9 and newer release cycle

Links:

Drop Python 3.6 support?

Also, just bringing up the topic of whether we should follow NEP 29 — Recommend Python and Numpy version support as a community policy standard as noted before in #340 (comment). This would mean dropping support for Python 3.6.

In practice, we'll need to follow in the footsteps of our dependent packages:

Some options we can take are:

  1. Agressive option - Do a PyGMT v0.2.1 release which is the last version to support Python 3.6, and state that PyGMT v0.3.0 requires Python 3.7 or newer.
  2. Less aggressive option - Still support Python 3.6 for PyGMT v0.3.0 (but maybe drop it from our test suite to save on CI resources).

Are you willing to help implement and maintain this feature? Yes

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Oct 8, 2020
@weiji14 weiji14 added this to the 0.3.0 milestone Oct 8, 2020
@seisman
Copy link
Member

seisman commented Oct 8, 2020

It's a little unclear to me what exactly "Dropping Python 3.6 support" means. Does it mean that users cannot install pygmt via pip install pygmt or conda install pygmt if they're still using Python 3.6? Or they can still install it, but there is no guarantee that all PyGMT functionalities work well with Python 3.6?

@weiji14
Copy link
Member Author

weiji14 commented Oct 8, 2020

Does it mean that users cannot install pygmt via pip install pygmt or conda install pygmt if they're still using Python 3.6? Or they can still install it, but there is no guarantee that all PyGMT functionalities work well with Python 3.6?

It will be quite hard to support four minor versions of Python (3.6, 3.7, 3.8, 3.9), especially for the conda packages where there is a separate build for each one (unless we can work out how to get a 'noarch' build). We could still allow pip install pygmt Python 3.6 (with no support guarantees, i.e. no CI checks), but it will become a maintenance burden when our dependency packages (numpy, pandas, xarray) move on.

There's no rush to do all this, since Python 3.9 is just released, and there are some libraries still to catch up. Even matplotlib (who has more maintainers) is dropping Python 3.6 for their v3.4 (see matplotlib/matplotlib#17662) so it's worth thinking about following NEP 29 for PyGMT v0.3.0.

@seisman
Copy link
Member

seisman commented Nov 14, 2020

Re-open this issue? Or open a new issue for dropping Python 3.6 support?

@weiji14
Copy link
Member Author

weiji14 commented Nov 14, 2020

I'll open a new one and copy the thread across.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants