-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 1-D/2-D numpy arrays with longlong and ulonglong dtype #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
labels
Nov 4, 2024
michaelgrund
approved these changes
Nov 4, 2024
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Nov 5, 2024
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2848 (comment) for context.
np.longlong
andnp.ulonglong
are valid numpy dtypes and are almost the same asnp.int64
/np.uint64
(xref: https://numpy.org/devdocs/reference/arrays.scalars.html#numpy.int64), although there are technical differences (xref: numpy/numpy#12264).As shown below, a
np.longlong
array is shown with theint64
dtype, butx.dtype.type
is stillnp.longlong
, which means it can't be recognized by_check_dtype_and_dim
.This PR adds support for
np.longlong
andnp.ulonglong
by mapping them toGMT_LONG
andGMT_ULONG
respectively.Need to wait for #3565 first so that the newly supported dtypes are tested.These newly supported dtypes are automatically tested after #3565.