Replace the list of support numpy dtypes with DTYPES_NUMERIC in tests #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
commented
Oct 31, 2024
| return "int8 int16 int32 int64 uint8 uint16 uint32 uint64 float32 float64".split() | ||
|
|
||
|
|
||
| @pytest.fixture(scope="module", name="dtypes_pandas") |
There was a problem hiding this comment.
This fixture is no longer used in this file.
seisman
changed the title
seisman
changed the title
seisman
commented
Oct 31, 2024
| @@ -43,7 +45,7 @@ def test_grdimage_image_dataarray(xr_image): | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "dtype", | |||
| ["int8", "uint16", "int16", "uint32", "int32", "float32", "float64"], | |||
| [dtype for dtype in DTYPES_NUMERIC if dtype not in {np.uint8, np.timedelta64}], | |||
There was a problem hiding this comment.
Currently, only uint8 images are supported.
seisman
added
final review call
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long list of supported numpy types are used in many places. Currently, we usually use
it can be replaced by:
This is also a small step towards #3547.