Figure.meca: Refactor tests for plotting a single focal mechanism

[seisman]

Description of proposed changes

The Figure.meca tests are a little messy and difficult to maintain because each test uses different focal mechanisms and event information.

I plan to refactor the tests. This PR focuses on testing passing a single focal mechanism to the spec parameter using different data types (dict, file, 1darray and DataFrame). Note that all tests now single a single baseline image test_meca_spec_dict.png.

Changes in this PR:

• Rename test_meca_spec_dictionary to test_meca_spec_single_focalmecha
• Test different input types for a single focal mechanism
• Remove test_meca_spec_file and add test_meca_spec_single_focalmecha_file
• Remove two tests test_meca_gcmt_convention and test_meca_spec_1d_array

This PR is a rework of PR #2219.

Reminders

• Run make format and make check to make sure the code follows the style guide.
• Add tests for new features or tests that would have caught the bug that you're fixing.
• Add new public functions/methods/classes to doc/api/index.rst.
• Write detailed docstrings for all functions/methods.
• If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
• If adding new functionality, add an example to docstrings or tutorials.
• Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

• /format: automatically format and lint the code
• /test-gmt-dev: run full tests on the latest GMT development version

[seisman]

Different inputtype are different ways to passing a single focal mechanism to the spec parameter.

[github-actions]

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status	Path
added	pygmt/tests/baseline/test_meca_spec_single_focalmecha.png
deleted	pygmt/tests/baseline/test_meca_gcmt_convention.png
deleted	pygmt/tests/baseline/test_meca_spec_1d_array.png
deleted	pygmt/tests/baseline/test_meca_spec_dictionary.png
deleted	pygmt/tests/baseline/test_meca_spec_file.png

Image diff(s)

Added images

• pygmt/tests/baseline/test_meca_spec_single_focalmecha.png

Modified images

Path	Old	New

Report last updated at commit 0c6bc53

[weiji14]

The updated unit test test_meca_spec_single_focalmecha looks good, but the dvc-diff.yml workflow seems broken. Do you think it would be better to fix the dvc workflow in a separate PR?

[weiji14]

The generated markdown for this is ![](pygmt/tests/baseline-new/test_meca_spec_single_focalmecha.png) which doesn't show up since it points to a local path. Need to update this somehow?

[weiji14]

There's this deprecation warning on https://github.com/GenericMappingTools/pygmt/actions/runs/5107768299/jobs/9180964772#step:6:55:

Warning: "cml publish" is deprecated since "cml comment" now supports "![inline](./asset.png)"

Looks like we should be using cml comment --publish=true instead now, xref https://cml.dev/doc/ref/comment?

[weiji14]

Ah wait, just noticed you did try to use cml comment in 0c6bc53. Nevermind then.

[seisman]

but the dvc-diff.yml workflow seems broken. Do you think it would be better to fix the dvc workflow in a separate PR?

The changes to the dvc-diff workflow file was reverted in commit abe334e. I'll open a separate PR to fix the dvc-diff workflow.