Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.meca: Refactor tests for plotting multiple focal mechanisms #2565

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 5, 2023

Description of proposed changes

Followup PR of PR #2533.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added this to the 0.10.0 milestone Jun 5, 2023
@seisman seisman added the maintenance Boring but important stuff for the core devs label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
deleted pygmt/tests/baseline/test_meca_loc_array.png
deleted pygmt/tests/baseline/test_meca_spec_2d_array.png
deleted pygmt/tests/baseline/test_meca_spec_dataframe.png
renamed pygmt/tests/baseline/test_meca_spec_dict_list.png -> pygmt/tests/baseline/test_meca_spec_multiple_focalmecha.png

Image diff(s)

Added images

Modified images

Path Old New

Report last updated at commit c17f091

@seisman seisman changed the title WIP: Figure.meca: Refactor tests for plotting multiple focal mechanisms Figure.meca: Refactor tests for plotting multiple focal mechanisms Jun 6, 2023
@seisman seisman marked this pull request as ready for review June 6, 2023 05:01
@seisman seisman added the needs review This PR has higher priority and needs review. label Jun 6, 2023
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jun 6, 2023
@seisman seisman merged commit 7404011 into main Jun 7, 2023
@seisman seisman deleted the meca/refactor2 branch June 7, 2023 04:03
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants