Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "frame" parameter for the first figure of the gallery example "Timestamp" #2418

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Set "frame" parameter for the first figure of the gallery example "Timestamp" #2418

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef622ad
Set 'frame' parameter in first code example
yvonnefroehlich Mar 13, 2023
77a0ae3
Uses second figure as thumbnail
yvonnefroehlich Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/gallery/embellishments/timestamp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import pygmt

Copy link
Member

@weiji14 weiji14 Mar 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kimda unrelated, but at L13, did we want to use the first or second figure for the thumbnail in the gallery? The second one shows the 'Powered by PyGMT'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds a good idea to use the second one as the thumbnail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, using the second figure as the thumbnail is fine. I changed this in commit 77a0ae3.
Hope @michaelgrund also agrees, since he added this example 🙂.

fig = pygmt.Figure()
fig.basemap(region=[20, 30, -10, 10], projection="X10c/5c")
fig.basemap(region=[20, 30, -10, 10], projection="X10c/5c", frame=True)
fig.timestamp()
fig.show()

Expand Down