Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "frame" parameter for the first figure of the gallery example "Timestamp" #2418

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Mar 13, 2023

Description of proposed changes

This PR aims to set the frame parameter of pygmt.Figure.basemap for the first figure of the gallery example Timestamp.

Related to the changes in PR #2417 to fix issue #2356.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Mar 14, 2023
@@ -15,7 +15,7 @@
import pygmt

Copy link
Member

@weiji14 weiji14 Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kimda unrelated, but at L13, did we want to use the first or second figure for the thumbnail in the gallery? The second one shows the 'Powered by PyGMT'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds a good idea to use the second one as the thumbnail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, using the second figure as the thumbnail is fine. I changed this in commit 77a0ae3.
Hope @michaelgrund also agrees, since he added this example 🙂.

@seisman seisman merged commit 5bdb61a into main Mar 14, 2023
@seisman seisman deleted the add-frame-gallery-timestamp branch March 14, 2023 08:17
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants