-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pygmt.surface: Add aliases for "C", "L", "M", and "T" #2321
Conversation
💖 Thanks for opening this pull request! 💖 Please make sure you read our contributing guidelines and abide by our code of conduct. A few things to keep in mind:
|
Welcome 🙂 and great that you started working on this issue @JingHuiTong! Please add the related issue number #2222 under Beside adding an alias for Lines 55 to 71 in 8854774
One tipp for further contributions, which are highly welcome 🚀: It is better to create a feature branch from the main branch of your personal fork, instead of directly pushing to the main branch. |
May I add more alias -L -M -C? (Inspire by #1660) |
Sure! But you'll need to document each one 😁 |
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the 'Style Checks', you can either write /format
as a comment to have the automated bot format things automatically on GitHub, or do it manually as I mentioned just now in the video call 😉 Let us know if you have any other questions!
Co-authored-by: Wei Ji <[email protected]>
Sorry, I meant /format in a GitHub comment, not git commit comment 😅 |
Ha! I know it after trying. |
Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Yvonne Fröhlich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JingHuiTong, hope you had a nice holiday break! Just one last suggestion, otherwise everything looks good to me!
Will wait for one or two other reviewers to approve before we merge this in, just to double check 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except the minor comment and the merge conflicts.
/format |
Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Yvonne Fröhlich <[email protected]>
🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉 Please open a new pull request to add yourself to the |
Woohoo, thanks again @JingHuiTong! Definitely let us know if you're interested in contributing more stuff, I'm sure you've got plenty of fresh ideas :D |
Description of proposed changes
adding T=''tensor in surface.py
Fixes #2222
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version