Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pygmt.surface] tension_factor #2222

Closed
jhtong33 opened this issue Dec 5, 2022 · 2 comments · Fixed by #2321
Closed

[pygmt.surface] tension_factor #2222

jhtong33 opened this issue Dec 5, 2022 · 2 comments · Fixed by #2321
Assignees
Labels
feature request New feature wanted good first issue Good for newcomers
Milestone

Comments

@jhtong33
Copy link
Contributor

jhtong33 commented Dec 5, 2022

Description of the desired feature

Hello,
I want to request the feature about surface-tension_factor (-T)
Due to this problem, we need to transfer pygmt to GMT6.2.0 now.
Hoping the feature in GMT can implement in pygmt in the future.

Thanks!

Are you willing to help implement and maintain this feature?

Maybe

@jhtong33 jhtong33 added the feature request New feature wanted label Dec 5, 2022
@weiji14
Copy link
Member

weiji14 commented Dec 5, 2022

Hi @JingHuiTong. This isn't documented, but you can try using

grid = pygmt.surface(...,  T=0.35)

See example at https://www.generic-mapping-tools.org/egu22pygmt/lidar_to_surface.html#turn-points-into-a-grid.

If you do want to implement this feature, please add T="tension" alias to the pygmt/src/surface.py file at

@use_alias(
I="spacing",
R="region",
G="outgrid",
V="verbose",
a="aspatial",
b="binary",
d="nodata",
e="find",
f="coltypes",
h="header",
i="incols",
r="registration",
w="wrap",
)

@weiji14 weiji14 added the good first issue Good for newcomers label Dec 5, 2022
@jhtong33 jhtong33 closed this as completed Dec 5, 2022
@jhtong33
Copy link
Contributor Author

jhtong33 commented Dec 5, 2022

WOW! Thanks!!!
This information help me a lot. I have already shared the good news with my friends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature wanted good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants