-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated load_mars_shape function (deprecated since v0.6.0) #2304
Conversation
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
Before we continue, please solve the conflicts @willschlitzer 😉 |
Co-authored-by: Michael Grund <[email protected]>
pygmt/datasets/samples.py
Outdated
if name in load_func_old: | ||
data = load_func_old[name](suppress_warning=True) | ||
elif name in load_func: | ||
if name in load_func: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already checked if a valid name is given at line 66, so no need to check if name in load_func
.
Please change:
if name in load_func:
data = load_func[name]()
return data
to
return load_func[name]()
Kindly ping @willschlitzer to see if you have time to finalize this PR. |
Apologies for the delay; visited family over the weekend (I'm going to be an uncle! 🥳 ). |
Removes the deprecated function
load_mars_shape
and replaces it with_load_mars_shape
.Addresses: #2302
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version