Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated load_xx functions in v0.9.0 (deprecated since v0.6.0) #2302

Closed
7 tasks done
seisman opened this issue Jan 4, 2023 · 3 comments
Closed
7 tasks done
Labels
deprecation Deprecating a feature
Milestone

Comments

@seisman
Copy link
Member

seisman commented Jan 4, 2023

In PR #1685, we added a single load_sample_data function to load sample data used in tutorials and examples, and deprecated load_xx functions like load_japan_quakes in v0.6.0. These deprecated functions will be removed in v0.9.0.

Since our next targeted release is v0.9.0, now it's time to remove these deprecated functions. IMHO, we should remove these deprecated functions as early as possible, rather than removing them a few days before we make the v0.9.0 release. In this way, we can have more time (3 months vs a few days) to know whether removing these functions would cause any unexpected problems.

This issue is created to track the progress of removing these functions.

I've made the PR #2301 to remove the deprecated load_japan_quakes function. This PR could be used as a reference if anyone wants to work on other deprecated functions.

@willschlitzer
Copy link
Contributor

@michaelgrund Since we're working at the same time, I'm holding off on load_hotspots and assuming you're working on it. Let me know if you want me to add a PR to remove it!

@seisman
Copy link
Member Author

seisman commented Jan 5, 2023

Thank @michaelgrund and @willschlitzer for your quick PRs. I think we need to review/merge these PRs one by one to avoid unnecessary conflicts, so please be patient.

@yvonnefroehlich
Copy link
Member

In this context, I feel it would be helpful to also work on issue #1774 and the related PR #1814 by @maxrjones for adding a list or an overview of the available sample datasets 🙂. Currently, users do not know directly from the documentation which sample datasets are available via datasets.load_sample_data and have to run datasets.list_sample_data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

No branches or pull requests

3 participants