Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frame="a" in colorbars_multiple.py #1650

Merged
merged 2 commits into from
Dec 12, 2021
Merged

Use frame="a" in colorbars_multiple.py #1650

merged 2 commits into from
Dec 12, 2021

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR changes frame=True to frame="a" in the colorbars_multiple.py gallery example, as a workaround to GenericMappingTools/gmt#6100 in order to allow updating the GMT version to 6.3.0 (#1649).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Dec 11, 2021
@seisman seisman added this to the 0.6.0 milestone Dec 12, 2021
@maxrjones maxrjones merged commit 3c4b003 into main Dec 12, 2021
@maxrjones maxrjones deleted the gallery-workaround branch December 12, 2021 15:59
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants