-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the minimum required GMT version to 6.3.0 #1649
Conversation
The gallery example |
Traceback Unexpected failing examples:
/home/runner/work/pygmt/pygmt/examples/gallery/embellishments/colorbars_multiple.py failed leaving traceback:
Traceback (most recent call last):
File "/home/runner/work/pygmt/pygmt/examples/gallery/embellishments/colorbars_multiple.py", line 31, in <module>
fig.grdimage(grid=grid_globe, projection="R?", region="g", frame=True)
File "/usr/share/miniconda3/envs/pygmt/lib/python3.9/site-packages/pygmt/helpers/decorators.py", line 586, in new_module
return module_func(*args, **kwargs)
File "/usr/share/miniconda3/envs/pygmt/lib/python3.9/site-packages/pygmt/helpers/decorators.py", line 726, in new_module
return module_func(*args, **kwargs)
File "/usr/share/miniconda3/envs/pygmt/lib/python3.9/site-packages/pygmt/src/grdimage.py", line 175, in grdimage
lib.call_module("grdimage", arg_str)
File "/usr/share/miniconda3/envs/pygmt/lib/python3.9/site-packages/pygmt/clib/session.py", line 500, in call_module
raise GMTCLibError(
pygmt.exceptions.GMTCLibError: Module 'grdimage' failed with status code 72:
Error: e [ERROR]: Option -B parsing failure. Correct syntax:
Error: e [ERROR]: Offending option -B Relevant line that is failing
I would prefer that the Docs CI tests passes before this PR is merged. Maybe find a way to modify that gallery example a bit to workaround the upstream bug. |
Removing |
Yeah, not sure whether it's a problem with Either way, we probably do need to remove |
In GMT 6.3, it's not longer working to use -B without any arguments inside subplot mode:
I can try to track down this regression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok ✅ from me. The new dcw-gmt package's GMT 6.3.0 requirement is breaking the main branch's CI, so best to move ahead with this (even though it is a busy AGU week)!
Yes, sorry for the awful timing. Hopefully we'll have a patch release for the dcw bug soon (GenericMappingTools/dcw-gmt#39), but merging this will be quicker. |
Description of proposed changes
Bump the minimum required GMT version from 6.2.0 to 6.3.0. Also update GitHub Actions CI workflows to use GMT 6.3.0.
Relates to #1644. Supersedes #1321.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version