Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing aliases to grdproject #1514

Merged
merged 9 commits into from
Oct 7, 2021
Merged

Add missing aliases to grdproject #1514

merged 9 commits into from
Oct 7, 2021

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Sep 16, 2021 •
edited
Loading

This pull request is a follow up to #1377, and adds optional parameters to grdproject.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the enhancement Improving an existing feature label Sep 16, 2021
@willschlitzer willschlitzer added this to the 0.5.0 milestone Sep 16, 2021
@willschlitzer willschlitzer self-assigned this Sep 16, 2021
@willschlitzer willschlitzer marked this pull request as ready for review September 25, 2021 07:29
weiji14
weiji14 reviewed Oct 5, 2021
View reviewed changes
pygmt/src/grdproject.py Outdated Show resolved Hide resolved
pygmt/src/grdproject.py Outdated Show resolved Hide resolved
pygmt/src/grdproject.py Outdated Show resolved Hide resolved
pygmt/src/grdproject.py Outdated Show resolved Hide resolved
@weiji14 weiji14 added documentation Improvements or additions to documentation and removed enhancement Improving an existing feature labels Oct 5, 2021
weiji14
weiji14 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok from me, but might want to standardize the title of this PR with #1506 before merging.

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Oct 5, 2021
@willschlitzer willschlitzer changed the title Add optional parameters to grdproject Add missing aliases to grdproject Oct 5, 2021
@willschlitzer willschlitzer added the skip-changelog Skip adding Pull Request to changelog label Oct 5, 2021
seisman
seisman reviewed Oct 5, 2021
View reviewed changes
pygmt/src/grdproject.py Outdated Show resolved Hide resolved
pygmt/src/grdproject.py Outdated Show resolved Hide resolved
seisman
seisman reviewed Oct 5, 2021
View reviewed changes
pygmt/src/grdproject.py Outdated Show resolved Hide resolved
@willschlitzer willschlitzer merged commit d4d3a4d into main Oct 7, 2021
@willschlitzer willschlitzer deleted the add-params-grdproject branch October 7, 2021 05:32
@willschlitzer willschlitzer removed the final review call This PR requires final review and approval from a second reviewer label Dec 7, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer @weiji14 @seisman
Add missing aliases to grdproject (GenericMappingTools#1514)
837e81f 
*Add center, spacing, dpi, scaling, and unit aliases to grdproject

Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

@seisman seisman seisman approved these changes

Assignees

@willschlitzer willschlitzer

Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@willschlitzer @seisman @weiji14