Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap grdproject #1377

Merged
merged 19 commits into from
Aug 28, 2021
Merged

Wrap grdproject #1377

merged 19 commits into from
Aug 28, 2021

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Jul 7, 2021

This pull requests wraps the GMT module grdproject.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the feature Brand new feature label Jul 7, 2021
@willschlitzer willschlitzer added this to the 0.5.0 milestone Jul 7, 2021
@willschlitzer willschlitzer self-assigned this Jul 7, 2021
@willschlitzer willschlitzer changed the title WIP: Wrap grdproject Wrap grdproject Jul 11, 2021
@willschlitzer willschlitzer marked this pull request as ready for review July 22, 2021 19:54
@maxrjones
Copy link
Member

Thanks for wrapping this module!

What do you think about adding a value-based check to the tests (using npt.assert_allclose(), similar to grdgradient tests), in addition to the current metadata-based checks?

@willschlitzer
Copy link
Contributor Author

Thanks for wrapping this module!

What do you think about adding a value-based check to the tests (using npt.assert_allclose(), similar to grdgradient tests), in addition to the current metadata-based checks?

I'll add them in!

pygmt/tests/test_grdproject.py Outdated Show resolved Hide resolved
pygmt/src/grdproject.py Outdated Show resolved Hide resolved
pygmt/src/grdproject.py Show resolved Hide resolved
pygmt/src/grdproject.py Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Aug 26, 2021
@seisman
Copy link
Member

seisman commented Aug 26, 2021

@willschlitzer Please resolve the conflicts.

Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@seisman
Copy link
Member

seisman commented Aug 27, 2021

/format

@seisman
Copy link
Member

seisman commented Aug 27, 2021

@willschlitzer Please see my above suggestion. Otherwise, I think this PR is ready to merge.

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 28, 2021
@seisman seisman merged commit fb90068 into main Aug 28, 2021
@seisman seisman deleted the wrap-grdproject branch August 28, 2021 16:59
@weiji14 weiji14 mentioned this pull request Sep 2, 2021
5 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants