Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap sphdistance #1383

Merged
merged 16 commits into from
Sep 10, 2021
Merged

Wrap sphdistance #1383

merged 16 commits into from
Sep 10, 2021

Conversation

willschlitzer
Copy link
Contributor

This pull request wraps the gmt module sphdistance.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the feature Brand new feature label Jul 11, 2021
@willschlitzer willschlitzer added this to the 0.5.0 milestone Jul 11, 2021
@willschlitzer willschlitzer self-assigned this Jul 11, 2021
@willschlitzer willschlitzer changed the title WIP: Wrap sphdistance Wrap sphdistance Aug 8, 2021
@willschlitzer willschlitzer marked this pull request as ready for review August 11, 2021 08:54
pygmt/src/sphdistance.py Outdated Show resolved Hide resolved
pygmt/src/sphdistance.py Outdated Show resolved Hide resolved
pygmt/src/sphdistance.py Show resolved Hide resolved
pygmt/src/sphdistance.py Outdated Show resolved Hide resolved
pygmt/tests/test_sphdistance.py Outdated Show resolved Hide resolved
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me 😁

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Sep 9, 2021
pygmt/src/sphdistance.py Outdated Show resolved Hide resolved
pygmt/src/sphdistance.py Outdated Show resolved Hide resolved
pygmt/tests/test_sphdistance.py Outdated Show resolved Hide resolved
pygmt/tests/test_sphdistance.py Outdated Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman seisman merged commit 2edaa63 into main Sep 10, 2021
@seisman seisman deleted the wrap-sphdistance branch September 10, 2021 05:08
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 10, 2021
@maxrjones
Copy link
Member

Sorry for the comment after merging, but I think this needs to be in 'operations on tabular data' rather than 'operations on grids'.

Also the 'table' parameter is missing from the docstring (#1479 (comment) is relevant here).

@willschlitzer
Copy link
Contributor Author

Sorry for the comment after merging, but I think this needs to be in 'operations on tabular data' rather than 'operations on grids'.

Also the 'table' parameter is missing from the docstring (#1479 (comment) is relevant here).

I'll open a PR to fix it

sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants