-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common alias spacing (-I) for specifying grid increments #1288
Conversation
One thing I've been meaning to ask about at the |
The +e|n are modifiers that can be appended in addition to the units. For example: |
I can't find the original discussions in the GMT repository, but I believe the GMT developers agree with omitting units in the synopsis to make it shorter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Co-authored-by: Dongdong Tian <[email protected]>
Ok, fixed with cab6ac1 (thanks @seisman)! Preview now looks ok, though not sure why it's starting on a different line still:
I've followed the format in https://github.com/GenericMappingTools/gmt/blob/6.2.0rc1/doc/rst/source/explain_-I.rst_ which is used in most of upstream GMT, though you're right that there is some inconsistency throughout the documentation pages. Personally, the |
…MappingTools#1288) Used to specify the grid spacing. See also https://github.com/GenericMappingTools/gmt/blob/6.2.0rc1/doc/rst/source/explain_-I.rst_. * Use standardized spacing (I) docstring in blockmean, blockmedian, grdfilter and surface Co-authored-by: Dongdong Tian <[email protected]>
Description of proposed changes
Used to specify the grid spacing. See also https://github.com/GenericMappingTools/gmt/blob/6.2.0rc1/doc/rst/source/explain_-I.rst_
Preview at https://pygmt-git-common-aliases-spacing-gmt.vercel.app/api/generated/pygmt.surface.html
This PR expands and standardizes the spacing (-I) parameter's docstring in
blockmean
,blockmedian
,grdfilter
andsurface
. The{I}
common option will also be useful for many future PyGMT modules according to https://github.com/GenericMappingTools/pygmt/pull/1273/files#r637586300:Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version