Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow x/y/z input for blockmedian and blockmean #1319

Merged
merged 6 commits into from
Jun 18, 2021
Merged

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Jun 4, 2021

Description of proposed changes

This PR adds the option to provide input data as x/y/z for blockmean and blockmedian.

Addresses ##1099

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones
Copy link
Member Author

It will also be necessary to add a w parameter for the weights, but I would prefer to do this in a separate PR that includes adding an alias.

@maxrjones maxrjones self-assigned this Jun 4, 2021
@maxrjones maxrjones marked this pull request as draft June 4, 2021 16:22
@weiji14 weiji14 added the enhancement Improving an existing feature label Jun 6, 2021
@maxrjones maxrjones requested a review from a team June 15, 2021 15:19
@maxrjones maxrjones mentioned this pull request Jun 15, 2021
27 tasks
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@maxrjones maxrjones marked this pull request as ready for review June 18, 2021 03:02
@maxrjones maxrjones added the final review call This PR requires final review and approval from a second reviewer label Jun 18, 2021
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@seisman seisman added this to the 0.4.0 milestone Jun 18, 2021
@maxrjones maxrjones merged commit c126a33 into master Jun 18, 2021
@maxrjones maxrjones deleted the blockm-xyz branch June 18, 2021 22:16
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Jun 23, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants