Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve input/output options for blockm* and grdtrack #1099

Closed
1 of 2 tasks
maxrjones opened this issue Mar 22, 2021 · 4 comments
Closed
1 of 2 tasks

Improve input/output options for blockm* and grdtrack #1099

maxrjones opened this issue Mar 22, 2021 · 4 comments
Assignees
Labels
enhancement Improving an existing feature

Comments

@maxrjones
Copy link
Member

maxrjones commented Mar 22, 2021

Description of the desired feature

Originally posted by @weiji14 in #1092 (comment)

  • Improve the input options for blockmedian, blockmode, and blockmean from only supporting pandas.DataFrame or file to supporting a file, matrix, pandas.DataFrame, or x/y/z.
  • Improve the output options to support pandas.DataFrame or a file, independent of the input choice (current implementation requires outfile if a data file is provided as the input).

Are you willing to help implement and maintain this feature? Yes

@maxrjones maxrjones added the enhancement Improving an existing feature label Mar 22, 2021
@weiji14
Copy link
Member

weiji14 commented Mar 22, 2021

I'll take the blame for this one. Just for context, the " pd.DataFrame in, pd.DataFrame out; filename in, filename out" restriction was added in a37fb0a when I was wrapping the grdtrack function at #308. Some of the blockmedian code was based on grdtrack, and was not really questioned ever since.

So we should also update the grdtrack code as well to have the same I/O design. I actually had a friend using grdtrack last week who would have loved to have file-in and pandas.DataFrame-out for grdtrack so I'll work on refactoring grdtrack while @meghanrjones can work on the blockm* I/O refactor.

@maxrjones maxrjones self-assigned this Mar 23, 2021
@weiji14 weiji14 self-assigned this Apr 6, 2021
@weiji14 weiji14 changed the title Improve input/output options for blockm* Improve input/output options for blockm* and grdtrack Apr 6, 2021
@maxrjones maxrjones linked a pull request May 24, 2021 that will close this issue
5 tasks
@weiji14 weiji14 mentioned this issue May 26, 2021
5 tasks
@maxrjones
Copy link
Member Author

@weiji14, do you mind if I work on a PR for x/y input for grdtrack?

@maxrjones
Copy link
Member Author

Just an update - I will hold off until after #1353 and #1336 are completed to submit the x/y input PR for grdtrack.

@weiji14 weiji14 added this to the 0.6.0 milestone Oct 31, 2021
@weiji14 weiji14 modified the milestones: 0.6.0, 0.6.1 Mar 13, 2022
@seisman seisman modified the milestones: 0.6.1, 0.7.0 Mar 18, 2022
@seisman seisman modified the milestones: 0.7.0, 0.8.0 Jun 23, 2022
@seisman seisman modified the milestones: 0.8.0, 0.9.0 Dec 11, 2022
@seisman seisman modified the milestones: 0.9.0, 0.10.0 Mar 16, 2023
@weiji14 weiji14 removed this from the 0.10.0 milestone Aug 29, 2023
@seisman
Copy link
Member

seisman commented Feb 29, 2024

The issue will be tracked in #2731 and #1318. Closing.

@seisman seisman closed this as completed Feb 29, 2024
@seisman seisman modified the milestone: 0.12.0 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants