Add regression test for grdimage plotting an xarray.DataArray grid subset #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bset Ensure that a sliced xarray.DataArray grid is plotted correctly on a global Mollweide projection map.
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
None Image diff(s)Added images
Modified images
Report last updated at commit 92afd51 |
seisman
approved these changes
Jun 2, 2021
Co-authored-by: Dongdong Tian <[email protected]>
|
Should this PR be labelled with 'skip-changelog' (and is using 'bug' better than 'maintenance', though the bugfix was actually done upstream)? |
"maintenance" only looks good to me. |
weiji14
added
the
final review call
weiji14
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…bset (GenericMappingTools#1314) Ensure that a sliced xarray.DataArray grid is plotted correctly on a global Mollweide projection map. This is a regression test to ensure that the bug reported in GenericMappingTools#732 does not happen in the future. Cross-reference upstream issue GenericMappingTools/gmt#5180, and PR GenericMappingTools/gmt#5181 where the bug was fixed. Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Ensure that a sliced xarray.DataArray grid is plotted correctly on a global Mollweide projection map. This is a regression test to ensure that the bug reported in #732 does not happen in the future.
Cross-reference upstream issue GenericMappingTools/gmt#5180, and PR GenericMappingTools/gmt#5181 where the bug was fixed.
Fixes #732
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version