Make sure projected region handles periodic boundaries #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #5180. Problem was that when we search along the grid perimeter we will fail when there are periodic boundaries and the w/e of the grid do not coincide with them.
joa-quim
approved these changes
Apr 29, 2021
5 tasks
weiji14
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
Jun 2, 2021
…bset (#1314) Ensure that a sliced xarray.DataArray grid is plotted correctly on a global Mollweide projection map. This is a regression test to ensure that the bug reported in #732 does not happen in the future. Cross-reference upstream issue GenericMappingTools/gmt#5180, and PR GenericMappingTools/gmt#5181 where the bug was fixed. Co-authored-by: Dongdong Tian <[email protected]>
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…bset (GenericMappingTools#1314) Ensure that a sliced xarray.DataArray grid is plotted correctly on a global Mollweide projection map. This is a regression test to ensure that the bug reported in GenericMappingTools#732 does not happen in the future. Cross-reference upstream issue GenericMappingTools/gmt#5180, and PR GenericMappingTools/gmt#5181 where the bug was fixed. Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5180. Problem was that when we search along the grid perimeter we will fail when there are periodic boundaries and the w/e of the grid do not coincide with them. Closes #5180.