Allow pygmt.which to accept a list of filenames as input #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the fname parameter in `pygmt.which` accept list inputs. List of filenames are parsed using the `sequence_space` and then passed into GMT C API as space delimited filenames. Also added a unit test to check that multi-file inputs work.
5 tasks
weiji14
commented
Jun 1, 2021
Comment on lines
39
to
41
| download : bool or str | ||
| If the file is downloadable and not found, we will try to download the | ||
| it. Use True or 'l' (default) to download to the current directory. Use |
There was a problem hiding this comment.
I'm tempted to update the download (-G) docstring to include the 'a' option (added in GMT 6.1 I think). Should it be done in this PR or a separate one?
Suggested change
| download : bool or str | |
| If the file is downloadable and not found, we will try to download the | |
| it. Use True or 'l' (default) to download to the current directory. Use | |
| download : bool or str | |
| If the file is downloadable and not found, we will try to download | |
| it. Use True or 'l' (default) to download to the current directory. Use |
There was a problem hiding this comment.
A separate one is better.
I agree.
weiji14
added
the
final review call
michaelgrund
approved these changes
Jun 1, 2021
Co-Authored-By: Michael Grund <[email protected]>
weiji14
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ingTools#1312) Let the fname parameter in `pygmt.which` accept list inputs. List of filenames are parsed using `sequence_space` and then passed into GMT C API as space delimited filenames. Also added a unit test to check that multi-file inputs work. Use case for this is to download multiple files at once using `pygmt.which` without going through a for-loop. Co-authored-by: Michael Grund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Let the fname parameter in
pygmt.whichaccept list inputs. List of filenames are parsed using thesequence_space(see #325) and then passed into GMT C API as space delimited filenames. Also added a unit test to check that multi-file inputs work.Use case for this is to download multiple files at once using
pygmt.whichwithout going through a for-loop, as in #1310.Addresses #1310 (comment)
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version