Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download_test_data to download data files used in tests #1310

Merged
merged 11 commits into from
Jun 2, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented May 29, 2021

Description of proposed changes

Fixes #1111.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

pygmt/helpers/testing.py Outdated Show resolved Hide resolved
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tag on the final-review-call label. Would appreciate it if @meghanrjones can give this a review before merging to see if the download_test_data() function does resolve the issue opened in #1111.

pygmt/helpers/testing.py Show resolved Hide resolved
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Jun 2, 2021
@seisman seisman added this to the 0.4.0 milestone Jun 2, 2021
@seisman seisman added the maintenance Boring but important stuff for the core devs label Jun 2, 2021
@seisman seisman force-pushed the download-test-data branch from c99bd96 to 270e3ea Compare June 2, 2021 04:05
@seisman seisman marked this pull request as ready for review June 2, 2021 04:30
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Yao Jiayuan <[email protected]>
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 2, 2021
@seisman seisman merged commit 1ab551d into master Jun 2, 2021
@seisman seisman deleted the download-test-data branch June 2, 2021 17:53
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providing a datasets.download_test_data() method
4 participants