Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing (required) parameters in grdlandmask #1421

Closed
michaelgrund opened this issue Aug 8, 2021 · 1 comment · Fixed by #1423
Closed

Missing (required) parameters in grdlandmask #1421

michaelgrund opened this issue Aug 8, 2021 · 1 comment · Fixed by #1423
Labels
question Further information is requested
Milestone

Comments

@michaelgrund
Copy link
Member

michaelgrund commented Aug 8, 2021

Description of the desired feature

I thought about generating a gallery example highlighting how to use grdlandmask (similar to #1396 for grdclip) based on the examples given under https://docs.generic-mapping-tools.org/6.2/grdlandmask.html. Please correct me if I'm wrong but for the case of plotting shoreslines already included in GMT at least the alias (and description) for parameter -N is missing, isn't it?

Are you willing to help implement and maintain this feature? Yes

@michaelgrund michaelgrund added the question Further information is requested label Aug 8, 2021
@maxrjones
Copy link
Member

-N is not a required arguments since there is a default in GMT (setting values over water as 0 and values over land as 1). It is certainly useful since it allows completing tasks such as those in the examples. Feel free to propose an alias in a PR, since there is not already a PR open for adding more aliases to grdlandmask.

@michaelgrund michaelgrund linked a pull request Aug 9, 2021 that will close this issue
5 tasks
michaelgrund added a commit that referenced this issue Aug 27, 2021
According to #1421 here's now the gallery example showcasing the use of ``grdlandmask``.
@seisman seisman added this to the 0.5.0 milestone Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants