Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery example for grdlandmask #1469

Merged
merged 12 commits into from
Sep 1, 2021
Merged

Add gallery example for grdlandmask #1469

merged 12 commits into from
Sep 1, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

According to #1421 here's now the gallery example showcasing the use of grdlandmask.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

According to #1421 here's now the gallery example showcasing the use of ``grdlandmask``.
@michaelgrund michaelgrund added the documentation Improvements or additions to documentation label Aug 27, 2021
@michaelgrund michaelgrund added this to the 0.5.0 milestone Aug 27, 2021
@michaelgrund
Copy link
Member Author

/format

@michaelgrund
Copy link
Member Author

/format

examples/gallery/images/grdlandmask.py Outdated Show resolved Hide resolved
examples/gallery/images/grdlandmask.py Outdated Show resolved Hide resolved
examples/gallery/images/grdlandmask.py Outdated Show resolved Hide resolved
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Aug 30, 2021
@seisman
Copy link
Member

seisman commented Aug 31, 2021

/format

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 1, 2021
@seisman seisman merged commit ce926e9 into main Sep 1, 2021
@seisman seisman deleted the gallery-grdlandmask branch September 1, 2021 01:54
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants