-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/profile not found errors #225
Conversation
…ileDetail and still render if either missing
…ileDetail and still render if either missing
…bKey prop or client.myPubKey changes
…ensure queryKey updates reactively when prop changes
…ensure reactive updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These filters aren't needed any longer https://github.com/GeekGene/mewsfeed/pull/225/files#diff-a2957e428e699ad1bdd854cf0f707ce494ae491aaaca72e4b5cf8c72a6127229L92
Fix/profile popup data incorrect
… agent name in lists & detail
yes, but it doesn't make sense for that component -- I'll remove it.
good catch -- fixed
|
It's the next line actually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pub key isn't abbreviated any longer. Please have a look at what's happening here. It could be because I messed with the load creators function to not load the profile for testing this:
const agentProfiles = await Promise.all(
agents.map(async (agentPubKey) => {
let profile;
try {
// profile = await profilesStore.client.getAgentProfile(agentPubKey);
} catch (error) {
console.error(error);
}
return {
agentPubKey,
profile,
} as unknown as AgentProfile;
})
);
Screen.Recording.2023-09-11.at.19.52.10.mov
I can't reproduce the issues seen the video. Going to merge for now to get a release out and we can see if they arise again. |
Cool, yeah |
Resolves #188
Don't require profile for any component, instead, gracefully degrade to displaying agent pub key in place of profile name